fix: wallet refresh button + internal send 0 amount display#71
Merged
Conversation
…amount Refresh mechanism: - Add refresh icon button next to balance display (calls getData with forceUpdate). Shows spinner while fetching. - Auto-refresh on tab/window focus via visibilitychange listener, debounced to 15s to avoid spamming the API. Internal send 0.000000 amount fix: - Root cause: getAddressCredentials called Address.staking_cred() which doesn't exist in CSL v15 (only BaseAddress.stake_cred() does). The thrown error caused all addresses to return [null, null] credentials, making null === null match everything. Both input and output UTxOs were included, netting to ~0. - Fix: cast Address to BaseAddress first, use stake_cred(). Fall back gracefully for RewardAddress and ByronAddress. - matchesAnyCredential now requires payment credential match when both addresses have one (not OR staking). Staking cred is fallback for reward addresses only. - 12 new unit tests covering credential matching, calculateAmount for internal/external sends and receives, and getTxType classification.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
visibilitychangelistener refreshes wallet data when the tab regains focus (debounced 15s)getAddressCredentialscalledAddress.staking_cred()which doesn't exist in CSL v15 (onlyBaseAddress.stake_cred()). The thrown error caused all addresses to return[null, null]credentials, sonull === nullmatched every UTxO output — netting to ~0. Fixed by casting toBaseAddressand usingstake_cred(). Also tightenedmatchesAnyCredentialto prefer payment credential match.Test plan
NODE_ENV=test npx jest)npm run build:webpack)